]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
udevadm: avoid side-effect in assert()
authorNRK <nrk@disroot.org>
Mon, 2 Oct 2023 19:26:48 +0000 (01:26 +0600)
committerLuca Boccassi <luca.boccassi@gmail.com>
Mon, 2 Oct 2023 21:58:45 +0000 (22:58 +0100)
this was found when trying to use __builtin_assume() with clang:
https://github.com/systemd/systemd/pull/29409#issuecomment-1743575402

src/udev/udevadm-lock.c

index aa99e5497f3829b4e7627382fec2a63ad177249b..89d7d256d2c4ab03c731b155e513eac7f0065364 100644 (file)
@@ -245,8 +245,8 @@ static int lock_device(
                                 sigset_t ss;
                                 usec_t n;
 
-                                assert(sigemptyset(&ss) >= 0);
-                                assert(sigaddset(&ss, SIGCHLD) >= 0);
+                                assert_se(sigemptyset(&ss) >= 0);
+                                assert_se(sigaddset(&ss, SIGCHLD) >= 0);
 
                                 n = now(CLOCK_MONOTONIC);
                                 if (n >= deadline)