]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
phy: zynqmp: fix L0_TM_DISABLE_SCRAMBLE_ENCODER mask
authorNava kishore Manne <nava.kishore.manne@amd.com>
Sat, 27 Jun 2026 15:52:27 +0000 (21:22 +0530)
committerVinod Koul <vkoul@kernel.org>
Wed, 22 Jul 2026 15:22:34 +0000 (20:52 +0530)
The L0_TX_DIG_61 register bit 2 is a reserved read-only field.
The previous mask value 0x0f incorrectly included bit 2, causing
unintended writes to a reserved bit on every scrambler bypass
operation.

Correct the mask to (BIT(3) | GENMASK(1, 0)) to cover only the
valid scramble bypass control bits.

Fixes: 4a33bea00314 ("phy: zynqmp: Add PHY driver for the Xilinx ZynqMP Gigabit Transceiver")
Cc: stable@vger.kernel.org
Signed-off-by: Nava kishore Manne <nava.kishore.manne@amd.com>
Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Acked-by: Michal Simek <michal.simek@amd.com>
Link: https://patch.msgid.link/20260627155229.2791113-2-radhey.shyam.pandey@amd.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/xilinx/phy-zynqmp.c

index 2138f5399821a95798e4a2783143587aaf22d5bc..58fa2f8376893902292e1dd42a105cf51831bacb 100644 (file)
@@ -53,7 +53,7 @@
 #define L0_TM_DIG_6                    0x106c
 #define L0_TM_DIS_DESCRAMBLE_DECODER   0x0f
 #define L0_TX_DIG_61                   0x00f4
-#define L0_TM_DISABLE_SCRAMBLE_ENCODER 0x0f
+#define L0_TM_DISABLE_SCRAMBLE_ENCODER (BIT(3) | GENMASK(1, 0))
 
 /* PLL Test Mode register parameters */
 #define L0_TM_PLL_DIG_37               0x2094