]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
PM / devfreq: mtk-cci: avoid redundant conditions
authorLiao Yuanhong <liaoyuanhong@vivo.com>
Wed, 3 Sep 2025 12:14:52 +0000 (20:14 +0800)
committerChanwoo Choi <cw00.choi@samsung.com>
Mon, 8 Sep 2025 08:19:25 +0000 (17:19 +0900)
While 'if (i <= 0) ... else if (i > 0) ...' is technically equivalent to
'if (i <= 0) ... else ...', the latter is vastly easier to read because
it avoids writing out a condition that is unnecessary. Let's drop such
unnecessary conditions.

Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Link: https://patchwork.kernel.org/project/linux-pm/patch/20250903121452.387023-1-liaoyuanhong@vivo.com/
drivers/devfreq/mtk-cci-devfreq.c

index 5730076846e1be9f43cdd6891dac477a8cee5a71..4c22be728f6a03faf3ab2ac1319056cc77d63fed 100644 (file)
@@ -86,7 +86,7 @@ static int mtk_ccifreq_set_voltage(struct mtk_ccifreq_drv *drv, int new_voltage)
                                                      soc_data->sram_max_volt);
                                return ret;
                        }
-               } else if (pre_voltage > new_voltage) {
+               } else {
                        voltage = max(new_voltage,
                                      pre_vsram - soc_data->max_volt_shift);
                        ret = regulator_set_voltage(drv->proc_reg, voltage,