]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
homed: generate proper error if we cannot create mountpoint for homedir
authorLennart Poettering <lennart@poettering.net>
Fri, 23 May 2025 10:15:45 +0000 (12:15 +0200)
committerLuca Boccassi <luca.boccassi@gmail.com>
Wed, 28 May 2025 18:16:16 +0000 (19:16 +0100)
Let's make this easier to debug. (When this failed for me due to disk
full it took me a bit to figure out what was going on.)

(cherry picked from commit 5b759bf5fd3a915a5b4756590caff7faf43a9693)
(cherry picked from commit 8158c87c36d5725818a2a9cda4270b8839553f86)

src/home/homework-mount.c

index 28f09b939feeca0891926c66c2d9af06ed428174..97e26b9d7e0aab716eea09861bc2046986dfbe60 100644 (file)
@@ -142,7 +142,9 @@ int home_move_mount(const char *mount_suffix, const char *target) {
         } else
                 d = HOME_RUNTIME_WORK_DIR;
 
-        (void) mkdir_p(target, 0700);
+        r = mkdir_p(target, 0700);
+        if (r < 0)
+                return log_error_errno(r, "Failed to create directory '%s': %m", target);
 
         r = mount_nofollow_verbose(LOG_ERR, d, target, NULL, MS_BIND, NULL);
         if (r < 0)