]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
RISC-V: KVM: Fix timer state restore
authorQiang Ma <maqianga@uniontech.com>
Tue, 26 May 2026 07:55:44 +0000 (15:55 +0800)
committerAnup Patel <anup@brainfault.org>
Thu, 4 Jun 2026 06:48:43 +0000 (12:18 +0530)
The KVM_REG_RISCV_TIMER_REG(state) one-reg write passes the value
written by userspace to kvm_riscv_vcpu_timer_next_event() when
re-enabling the timer.

That value is the timer state, KVM_RISCV_TIMER_STATE_ON, not the
timer compare value. During migration or state restore, userspace
restores the compare register separately, which stores the target
cycle in t->next_cycles. Re-arming the timer with the state value
schedules the next event at cycle 1 instead of the restored compare
value, causing the virtual timer to fire too early.

Use the restored compare value from t->next_cycles when turning the
timer back on.

Fixes: 3a9f66cb25e1 ("RISC-V: KVM: Add timer functionality")
Signed-off-by: Qiang Ma <maqianga@uniontech.com>
Reviewed-by: Anup Patel <anup@brainfault.org>
Link: https://lore.kernel.org/r/20260526075544.796396-1-maqianga@uniontech.com
Signed-off-by: Anup Patel <anup@brainfault.org>
arch/riscv/kvm/vcpu_timer.c

index 9817ff8028216095c77c5c23b6f84f705beb7927..ae53133c7ab035386ffd5a57c729653a003848d6 100644 (file)
@@ -231,7 +231,7 @@ int kvm_riscv_vcpu_set_reg_timer(struct kvm_vcpu *vcpu,
                break;
        case KVM_REG_RISCV_TIMER_REG(state):
                if (reg_val == KVM_RISCV_TIMER_STATE_ON)
-                       ret = kvm_riscv_vcpu_timer_next_event(vcpu, reg_val);
+                       ret = kvm_riscv_vcpu_timer_next_event(vcpu, t->next_cycles);
                else
                        ret = kvm_riscv_vcpu_timer_cancel(t);
                break;