]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
mfd: lp8788-irq: Uninitialized variable in irq handler
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 11 Mar 2016 08:11:39 +0000 (11:11 +0300)
committerBen Hutchings <ben@decadent.org.uk>
Mon, 22 Aug 2016 21:37:49 +0000 (22:37 +0100)
commit 22aab38e7b59fd79ce1045006be69a9abab58e5a upstream.

Instead to being true/false, the "handled" is true/uninitialized.
Presumably this doesn't cause that many problems in real life because
normally we handle the IRQ.

Fixes: eea6b7cc53aa ('mfd: Add lp8788 mfd driver')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Milo Kim <milo.kim@ti.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/mfd/lp8788-irq.c

index c84ded5f8ece0bcf0d13326eb96d137bd934a0b4..3bf5fac216406ff63ffe8d3d502e7fa268215835 100644 (file)
@@ -110,7 +110,7 @@ static irqreturn_t lp8788_irq_handler(int irq, void *ptr)
        struct lp8788_irq_data *irqd = ptr;
        struct lp8788 *lp = irqd->lp;
        u8 status[NUM_REGS], addr, mask;
-       bool handled;
+       bool handled = false;
        int i;
 
        if (lp8788_read_multi_bytes(lp, LP8788_INT_1, status, NUM_REGS))