[3.14] gh-145376: Fix various reference leaks (GH-145377) (GH-145712)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

diff --git a/Misc/NEWS.d/next/Core_and_Builtins/2026-02-28-16-46-17.gh-issue-145376.lG5u1a.rst b/Misc/NEWS.d/next/Core_and_Builtins/2026-02-28-16-46-17.gh-issue-145376.lG5u1a.rst
new file mode 100644 (file)
index 0000000..a5a6908
--- /dev/null
+++ b/Misc/NEWS.d/next/Core_and_Builtins/2026-02-28-16-46-17.gh-issue-145376.lG5u1a.rst
@@ -0,0 +1 @@
+Fix reference leaks in various unusual error scenarios.

diff --git a/Modules/main.c b/Modules/main.c
index 9b2ee103d5266290cf80ed598faa2f6152a09d93..15f51acbcf551f475f4b7d81cea26d3e3a091eb3 100644 (file)
--- a/Modules/main.c
+++ b/Modules/main.c
@@ -509,6 +509,7 @@ pymain_run_interactive_hook(int *exitcode)
     }
 
     if (PySys_Audit("cpython.run_interactivehook", "O", hook) < 0) {
+        Py_DECREF(hook);
         goto error;
     }
 

diff --git a/Python/crossinterp.c b/Python/crossinterp.c
index 80772fcedb46e63730746804b89a81de86cb7520..3b6c0c6e1eda4b8c6b0ee05f59f3e98b909d0a8f 100644 (file)
--- a/Python/crossinterp.c
+++ b/Python/crossinterp.c
@@ -609,6 +609,7 @@ check_missing___main___attr(PyObject *exc)
     // Get the error message.
     PyObject *args = PyException_GetArgs(exc);
     if (args == NULL || args == Py_None || PyObject_Size(args) < 1) {
+        Py_XDECREF(args);
         assert(!PyErr_Occurred());
         return 0;
     }

diff --git a/Python/pythonrun.c b/Python/pythonrun.c
index e005a509f6f0619f5d5d1ab9fa03406b144a7183..91c81ac0d8d23743e3c16866e0d538cd4ac6ee92 100644 (file)
--- a/Python/pythonrun.c
+++ b/Python/pythonrun.c
@@ -1151,6 +1151,7 @@ _PyErr_Display(PyObject *file, PyObject *unused, PyObject *value, PyObject *tb)
         "traceback",
         "_print_exception_bltin");
     if (print_exception_fn == NULL || !PyCallable_Check(print_exception_fn)) {
+        Py_XDECREF(print_exception_fn);
         goto fallback;
     }
 

diff --git a/Python/sysmodule.c b/Python/sysmodule.c
index 545b130836e26c7db770a743b270744c7483948b..c97042c99fa71e8e2d70ea518786d2f02de11300 100644 (file)
--- a/Python/sysmodule.c
+++ b/Python/sysmodule.c
@@ -1759,7 +1759,7 @@ sys_getwindowsversion_impl(PyObject *module)
     PyObject *realVersion = _sys_getwindowsversion_from_kernel32();
     if (!realVersion) {
         if (!PyErr_ExceptionMatches(PyExc_WindowsError)) {
-            return NULL;
+            goto error;
         }
 
         PyErr_Clear();