Fix the testing of the "res" variable so that it is more logically correct and

makes the correct warning and debug messages print.

(closes issue #12361)
Reported by: one47
Patches:
      chan_zap_deferred_digit.patch uploaded by one47 (license 23)

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@112599 65c4cc65-6c06-0410-ace0-fbb531ad65f3

diff --git a/channels/chan_zap.c b/channels/chan_zap.c
index 48d694f36fb43231701fc4cd0ea4ea2cffff58b8..45ca1320e477fcb92a6a9bec5c9a593aa7430c21 100644 (file)
--- a/channels/chan_zap.c
+++ b/channels/chan_zap.c
@@ -4413,14 +4413,15 @@ static struct ast_frame *zt_handle_event(struct ast_channel *ast)
                        case SIG_SF_FEATDMF:
                        case SIG_SF_FEATB:
                                /* FGD MF *Must* wait for wink */
-                               if (!ast_strlen_zero(p->dop.dialstr))
+                               if (!ast_strlen_zero(p->dop.dialstr)) {
                                        res = ioctl(p->subs[SUB_REAL].zfd, ZT_DIAL, &p->dop);
-                               else if (res < 0) {
-                                       ast_log(LOG_WARNING, "Unable to initiate dialing on trunk channel %d\n", p->channel);
-                                       p->dop.dialstr[0] = '\0';
-                                       return NULL;
-                               } else 
-                                       ast_log(LOG_DEBUG, "Sent deferred digit string: %s\n", p->dop.dialstr);
+                                       if (res < 0) {
+                                               ast_log(LOG_WARNING, "Unable to initiate dialing on trunk channel %d\n", p->channel);
+                                               p->dop.dialstr[0] = '\0';
+                                               return NULL;
+                                       } else 
+                                               ast_log(LOG_DEBUG, "Sent deferred digit string: %s\n", p->dop.dialstr);
+                               }
                                p->dop.dialstr[0] = '\0';
                                break;
                        default:
@@ -4441,14 +4442,15 @@ static struct ast_frame *zt_handle_event(struct ast_channel *ast)
                        case SIG_SF:
                        case SIG_SFWINK:
                        case SIG_SF_FEATD:
-                               if (!ast_strlen_zero(p->dop.dialstr)) 
+                               if (!ast_strlen_zero(p->dop.dialstr)) {
                                        res = ioctl(p->subs[SUB_REAL].zfd, ZT_DIAL, &p->dop);
-                               else if (res < 0) {
-                                       ast_log(LOG_WARNING, "Unable to initiate dialing on trunk channel %d\n", p->channel);
-                                       p->dop.dialstr[0] = '\0';
-                                       return NULL;
-                               } else 
-                                       ast_log(LOG_DEBUG, "Sent deferred digit string: %s\n", p->dop.dialstr);
+                                       if (res < 0) {
+                                               ast_log(LOG_WARNING, "Unable to initiate dialing on trunk channel %d\n", p->channel);
+                                               p->dop.dialstr[0] = '\0';
+                                               return NULL;
+                                       } else 
+                                               ast_log(LOG_DEBUG, "Sent deferred digit string: %s\n", p->dop.dialstr);
+                               }
                                p->dop.dialstr[0] = '\0';
                                p->dop.op = ZT_DIAL_OP_REPLACE;
                                break;