]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
r24057: Fix some uninitialized variables found by the IBM checker
authorVolker Lendecke <vlendec@samba.org>
Thu, 26 Jul 2007 16:39:48 +0000 (16:39 +0000)
committerGerald (Jerry) Carter <jerry@samba.org>
Wed, 10 Oct 2007 17:29:00 +0000 (12:29 -0500)
(This used to be commit d74bbc53c2cf41e7e92309e81bb9c1b3f805cdd1)

source3/utils/net_rpc_registry.c

index aac49dd7f90edf232ebd238922c41914e3971745..0d54ff390731715933ec41e36f64d5bf841d57c1 100644 (file)
@@ -70,6 +70,8 @@ static NTSTATUS registry_openkey(TALLOC_CTX *mem_ctx,
        NTSTATUS status;
        struct winreg_String key;
 
+       ZERO_STRUCT(key);
+
        if (!reg_hive_key(name, &hive, &key.name)) {
                return NT_STATUS_INVALID_PARAMETER;
        }
@@ -330,6 +332,8 @@ static NTSTATUS registry_setvalue(TALLOC_CTX *mem_ctx,
                return werror_to_ntstatus(err);
        }
 
+       ZERO_STRUCT(name_string);
+
        name_string.name = name;
        result = rpccli_winreg_SetValue(pipe_hnd, blob.data, key_hnd,
                                        name_string, value->type,
@@ -417,6 +421,8 @@ static NTSTATUS rpc_registry_deletevalue_internal(const DOM_SID *domain_sid,
        NTSTATUS status;
        struct winreg_String valuename;
 
+       ZERO_STRUCT(valuename);
+
        status = registry_openkey(mem_ctx, pipe_hnd, argv[0], REG_KEY_WRITE,
                                  &hive_hnd, &key_hnd);
        if (!NT_STATUS_IS_OK(status)) {
@@ -467,6 +473,9 @@ static NTSTATUS rpc_registry_createkey_internal(const DOM_SID *domain_sid,
        enum winreg_CreateAction action;
        NTSTATUS status;
 
+       ZERO_STRUCT(key);
+       ZERO_STRUCT(keyclass);
+
        if (!reg_hive_key(argv[0], &hive, &key.name)) {
                return NT_STATUS_INVALID_PARAMETER;
        }
@@ -533,6 +542,8 @@ static NTSTATUS rpc_registry_deletekey_internal(const DOM_SID *domain_sid,
        struct winreg_String key;
        NTSTATUS status;
 
+       ZERO_STRUCT(key);
+
        if (!reg_hive_key(argv[0], &hive, &key.name)) {
                return NT_STATUS_INVALID_PARAMETER;
        }