Fix a memory leak in tor-resolve

Resolves bug 14050

diff --git a/ChangeLog b/ChangeLog
index 4b7f35f5468fdb65bd8ed4a579a44e4adc0889ca..b125d9d8530531bea1dab45bbec72a330cb18a9d 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -145,6 +145,8 @@ Changes in version 0.2.6.2-alpha - 2014-12-??
     - Make transparent proxy support work along with the seccomp2
       sandbox. Fixes part of bug 13808; bugfix on 0.2.5.1-alpha. Patch
       by Francisco Blas Izquierdo Riera.
+    - Fix a memory leak in tor-resolve when running with the sandbox
+      enabled. Fixes bug 14050; bugfix on 0.2.5.9-rc.
 
   o Minor bugfixes (logging):
     - Downgrade warnings about RSA signature failures to info log level.

diff --git a/src/common/sandbox.c b/src/common/sandbox.c
index b1c2a09f1447e2e623f2b5431f5149d3bbd6dc6d..a06d38608f81e18a7afc6d68dcf6e64671552dc5 100644 (file)
--- a/src/common/sandbox.c
+++ b/src/common/sandbox.c
@@ -1335,6 +1335,13 @@ sandbox_disable_getaddrinfo_cache(void)
   sandbox_getaddrinfo_cache_disabled = 1;
 }
 
+void
+sandbox_freeaddrinfo(struct addrinfo *ai)
+{
+  if (sandbox_getaddrinfo_cache_disabled)
+    freeaddrinfo(ai);
+}
+
 int
 sandbox_getaddrinfo(const char *name, const char *servname,
                     const struct addrinfo *hints,

diff --git a/src/common/sandbox.h b/src/common/sandbox.h
index ad001865a78c15e6c6772acc2c76af8c3c91f9ab..f1c99ac02da4bffaa8ba03a477ae7822b13bf7a7 100644 (file)
--- a/src/common/sandbox.h
+++ b/src/common/sandbox.h
@@ -115,7 +115,7 @@ struct addrinfo;
 int sandbox_getaddrinfo(const char *name, const char *servname,
                         const struct addrinfo *hints,
                         struct addrinfo **res);
-#define sandbox_freeaddrinfo(addrinfo) ((void)0)
+void sandbox_freeaddrinfo(struct addrinfo *addrinfo);
 void sandbox_free_getaddrinfo_cache(void);
 #else
 #define sandbox_getaddrinfo(name, servname, hints, res)  \