misc: Fix clang -Wstring-plus-int warnings on syslog

clang issues:

syslog.c:193:9: error: adding 'int' to a string does not append to the string [-Werror,-Wstring-plus-int]
  193 |                       SYSLOG_HEADER (pri, timestamp, &msgoff, pid));
      |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
syslog.c:180:7: note: expanded from macro 'SYSLOG_HEADER'
  180 |   "[" + (pid == 0), pid, "]" + (pid == 0)

Use array indexes instead of string addition (it is simpler than
add a supress warning).

diff --git a/misc/syslog.c b/misc/syslog.c
index 4af87f54fdbe49bec65c637cab3a6e2397fe33ba..53bb33425918d10d68e21e3787a8bc27ee873f57 100644 (file)
--- a/misc/syslog.c
+++ b/misc/syslog.c
@@ -174,7 +174,7 @@ __vsyslog_internal (int pri, const char *fmt, va_list ap,
   "<%d>%s%n%s%s%.0d%s: ",                                \
   __pri, __timestamp, __msgoff,                          \
   LogTag == NULL ? __progname : LogTag,                  \
-  "[" + (pid == 0), pid, "]" + (pid == 0)
+  &"["[pid == 0], pid, &"]"[pid == 0]
 
 #define SYSLOG_HEADER_WITHOUT_TS(__pri, __msgoff)        \
   "<%d>: %n", __pri, __msgoff
@@ -274,7 +274,7 @@ __vsyslog_internal (int pri, const char *fmt, va_list ap,
   /* Output to stderr if requested. */
   if (LogStat & LOG_PERROR)
     __dprintf (STDERR_FILENO, "%s%s", buf + msgoff,
-              "\n" + (buf[bufsize - 1] == '\n'));
+              &"\n"[buf[bufsize - 1] == '\n']);
 
   /* Get connected, output the message to the local logger.  */
   if (!connected)