]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
gpu: nova-core: firmware: add comments to justify v3 header values
authorAlexandre Courbot <acourbot@nvidia.com>
Fri, 6 Mar 2026 04:52:45 +0000 (13:52 +0900)
committerAlexandre Courbot <acourbot@nvidia.com>
Mon, 9 Mar 2026 05:15:13 +0000 (14:15 +0900)
There is no member in `FalconUCodeDescV3` to describe the start offsets
of the IMEM and DMEM section in the firmware object. Add comments to
justify how they are computed.

Reviewed-by: Eliot Courtney <ecourtney@nvidia.com>
Link: https://patch.msgid.link/20260306-turing_prep-v11-8-8f0042c5d026@nvidia.com
Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
drivers/gpu/nova-core/firmware.rs

index 5eaa63ee3dfc4c726109d0128a930db88c07ad2a..fff5fa263c2621f9762f309e6a9efe332ba4afbb 100644 (file)
@@ -260,6 +260,7 @@ impl FalconUCodeDescriptor for FalconUCodeDescV3 {
 
     fn imem_sec_load_params(&self) -> FalconDmaLoadTarget {
         FalconDmaLoadTarget {
+            // IMEM segment always starts at offset 0.
             src_start: 0,
             dst_start: self.imem_phys_base,
             len: self.imem_load_size,
@@ -273,6 +274,7 @@ impl FalconUCodeDescriptor for FalconUCodeDescV3 {
 
     fn dmem_load_params(&self) -> FalconDmaLoadTarget {
         FalconDmaLoadTarget {
+            // DMEM segment starts right after the IMEM one.
             src_start: self.imem_load_size,
             dst_start: self.dmem_phys_base,
             len: self.dmem_load_size,