]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/xe/xe3p_lpm: Skip disabling NOA on unsupported IPs
authorBalasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
Fri, 17 Oct 2025 02:26:24 +0000 (19:26 -0700)
committerLucas De Marchi <lucas.demarchi@intel.com>
Fri, 17 Oct 2025 22:32:37 +0000 (15:32 -0700)
IP version 35 has removed "NOA Enable Signal" bit from RPM_CONFIG1
register. Skip clearing that bit on unsupported IPs.

Bspec: 62391
Signed-off-by: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Link: https://lore.kernel.org/r/20251016-xe3p-v3-5-3dd173a3097a@intel.com
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
drivers/gpu/drm/xe/xe_oa.c

index a4894eb0d7f3f36e575e764bc1a84b0d7060f753..f901ba52b403243dd1f7b0b8b5131bccdd694fb8 100644 (file)
@@ -837,7 +837,8 @@ static void xe_oa_disable_metric_set(struct xe_oa_stream *stream)
                xe_oa_configure_oa_context(stream, false);
 
        /* Make sure we disable noa to save power. */
-       xe_mmio_rmw32(mmio, RPM_CONFIG1, GT_NOA_ENABLE, 0);
+       if (GT_VER(stream->gt) < 35)
+               xe_mmio_rmw32(mmio, RPM_CONFIG1, GT_NOA_ENABLE, 0);
 
        sqcnt1 = SQCNT1_PMON_ENABLE |
                 (HAS_OA_BPC_REPORTING(stream->oa->xe) ? SQCNT1_OABPC : 0);