clk: versaclock: return value calculated by ERR_PTR

In versaclock_get_name -ENOMEM is passed to ERR_PTR but nothing is
done with the value that this calculates which is obviously not the
intention of the code. This is confirmed by the code around where this
function is called.
Instead return the value from ERR_PTR.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>

diff --git a/drivers/clk/clk_versaclock.c b/drivers/clk/clk_versaclock.c
index 9ccaf13d24202434b136108c9df1e8a80d8cb748..790ea4dbe82e9aca3c6572b0e56e1383eff2ccac 100644 (file)
--- a/drivers/clk/clk_versaclock.c
+++ b/drivers/clk/clk_versaclock.c
@@ -850,7 +850,7 @@ static char *versaclock_get_name(const char *dev_name, const char *clk_name, int
 
        buf = malloc(length);
        if (!buf)
-               ERR_PTR(-ENOMEM);
+               return ERR_PTR(-ENOMEM);
 
        if (index < 0)
                snprintf(buf, length, "%s.%s", dev_name, clk_name);