]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ARM: dts: exynos: correct PMIC interrupt trigger level on Monk
authorKrzysztof Kozlowski <krzk@kernel.org>
Thu, 10 Dec 2020 21:28:56 +0000 (22:28 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 4 Mar 2021 08:39:32 +0000 (09:39 +0100)
[ Upstream commit 8528cda2b7c667e9cd173aef1a677c71b7d5a096 ]

The Samsung PMIC datasheets describe the interrupt line as active low
with a requirement of acknowledge from the CPU.  Without specifying the
interrupt type in Devicetree, kernel might apply some fixed
configuration, not necessarily working for this hardware.

Fixes: e0cefb3f79d3 ("ARM: dts: add board dts file for Exynos3250-based Monk board")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20201210212903.216728-2-krzk@kernel.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/arm/boot/dts/exynos3250-monk.dts

index 6ffedf4ed9f2bd3a924960ef0f7a9ad9314e5f07..d343dc13ceecd68a6e4f5d0950bc29dc1011a4a6 100644 (file)
        s2mps14_pmic@66 {
                compatible = "samsung,s2mps14-pmic";
                interrupt-parent = <&gpx0>;
-               interrupts = <7 IRQ_TYPE_NONE>;
+               interrupts = <7 IRQ_TYPE_LEVEL_LOW>;
                reg = <0x66>;
                wakeup-source;