BUG/MINOR: ssl: Potential NULL deref in trace macro

'ctx' might be NULL when we exit 'ssl_sock_handshake', it can't be
dereferenced without check in the trace macro.

This was found by Coverity andraised in GitHub #3113.
This patch should be backported up to 3.2

diff --git a/src/ssl_sock.c b/src/ssl_sock.c
index 13339fa1b3328020ad582c80b5929ec74700ba05..1d40c11050a7f1805eef4dcc48177f2362c49f07 100644 (file)
--- a/src/ssl_sock.c
+++ b/src/ssl_sock.c
@@ -5943,7 +5943,7 @@ reneg_ok:
        if (!conn->err_code)
                conn->err_code = CO_ER_SSL_HANDSHAKE;
 
-       TRACE_ERROR("handshake error", SSL_EV_CONN_HNDSHK|SSL_EV_CONN_ERR, conn, ctx->ssl, &conn->err_code, (ctx ? &ctx->error_code : NULL));
+       TRACE_ERROR("handshake error", SSL_EV_CONN_HNDSHK|SSL_EV_CONN_ERR, conn, (ctx ? ctx->ssl : NULL), &conn->err_code, (ctx ? &ctx->error_code : NULL));
        return 0;
 }