]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
gh-124722: Fix leak in `test_detach_materialized_dict_no_memory` (GH-124769)
authorsobolevn <mail@sobolevn.me>
Mon, 30 Sep 2024 01:47:45 +0000 (04:47 +0300)
committerGitHub <noreply@github.com>
Mon, 30 Sep 2024 01:47:45 +0000 (20:47 -0500)
Lib/test/test_class.py

index d2b6a23cc3c10dc7e470aee33fe46f745b135be3..b88c4d16ba4ef474704caa403029c7974d228a19 100644 (file)
@@ -1,7 +1,7 @@
 "Test the functionality of Python classes implementing operators."
 
 import unittest
-import test.support
+from test.support import cpython_only, import_helper, script_helper
 
 testmeths = [
 
@@ -933,20 +933,36 @@ class TestInlineValues(unittest.TestCase):
         C.a = X()
         C.a = X()
 
+    @cpython_only
     def test_detach_materialized_dict_no_memory(self):
-        import _testcapi
-        class A:
-            def __init__(self):
-                self.a = 1
-                self.b = 2
-        a = A()
-        d = a.__dict__
-        with test.support.catch_unraisable_exception() as ex:
-            _testcapi.set_nomemory(0, 1)
-            del a
-            self.assertEqual(ex.unraisable.exc_type, MemoryError)
-        with self.assertRaises(KeyError):
-            d["a"]
+        # Skip test if _testcapi is not available:
+        import_helper.import_module('_testcapi')
+
+        code = """if 1:
+            import test.support
+            import _testcapi
+
+            class A:
+                def __init__(self):
+                    self.a = 1
+                    self.b = 2
+            a = A()
+            d = a.__dict__
+            with test.support.catch_unraisable_exception() as ex:
+                _testcapi.set_nomemory(0, 1)
+                del a
+                assert ex.unraisable.exc_type is MemoryError
+            try:
+                d["a"]
+            except KeyError:
+                pass
+            else:
+                assert False, "KeyError not raised"
+        """
+        rc, out, err = script_helper.assert_python_ok("-c", code)
+        self.assertEqual(rc, 0)
+        self.assertFalse(out, msg=out.decode('utf-8'))
+        self.assertFalse(err, msg=err.decode('utf-8'))
 
 if __name__ == '__main__':
     unittest.main()