]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
iio: adc: ti-ads1018: fix type overflow for data rate
authorChunyang Chen <chenchunyang0908@gmail.com>
Thu, 5 Mar 2026 12:43:02 +0000 (20:43 +0800)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sat, 7 Mar 2026 13:17:59 +0000 (13:17 +0000)
The variable 'drate' is currently defined as u8. However, the data rate
values in ads1018 can reach up to 3300 Hz, which exceeds the maximum
value of 255 that a u8 can hold.

Change the type of 'drate' to u32 to match the data_rate_mode_to_hz
array definition and ensure the data rate is handled correctly.

Fixes: bf0bba486b5b ("iio: adc: Add ti-ads1018 driver")
Signed-off-by: Chunyang Chen <chenchunyang0908@gmail.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Reviewed-by: Kurt Borja <kuurtb@gmail.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/ti-ads1018.c

index 6246b3cab71fd9887ef0f47fe3de99111bf9db15..0780abd0d0db42b1f3895c7ae74c50c8c5207db3 100644 (file)
@@ -249,7 +249,7 @@ static int ads1018_single_shot(struct ads1018 *ads1018,
                               struct iio_chan_spec const *chan, u16 *cnv)
 {
        u8 max_drate_mode = ads1018->chip_info->num_data_rate_mode_to_hz - 1;
-       u8 drate = ads1018->chip_info->data_rate_mode_to_hz[max_drate_mode];
+       u32 drate = ads1018->chip_info->data_rate_mode_to_hz[max_drate_mode];
        u8 pga_mode = ads1018->chan_data[chan->scan_index].pga_mode;
        struct spi_transfer xfer[2] = {
                {