]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ipmi: Use dev_warn_ratelimited() for incorrect message warnings
authorBreno Leitao <leitao@debian.org>
Thu, 10 Jul 2025 12:57:26 +0000 (05:57 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 28 Aug 2025 14:22:46 +0000 (16:22 +0200)
[ Upstream commit ec50ec378e3fd83bde9b3d622ceac3509a60b6b5 ]

During BMC firmware upgrades on live systems, the ipmi_msghandler
generates excessive "BMC returned incorrect response" warnings
while the BMC is temporarily offline. This can flood system logs
in large deployments.

Replace dev_warn() with dev_warn_ratelimited() to throttle these
warnings and prevent log spam during BMC maintenance operations.

Signed-off-by: Breno Leitao <leitao@debian.org>
Message-ID: <20250710-ipmi_ratelimit-v1-1-6d417015ebe9@debian.org>
Signed-off-by: Corey Minyard <corey@minyard.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/char/ipmi/ipmi_msghandler.c

index b89f300751b1b5d911197d6955ae718f31a9c06d..5b01985aed229fe3dd204a53a948b4ec6848ad76 100644 (file)
@@ -4307,10 +4307,10 @@ free_msg:
                 * The NetFN and Command in the response is not even
                 * marginally correct.
                 */
-               dev_warn(intf->si_dev,
-                        "BMC returned incorrect response, expected netfn %x cmd %x, got netfn %x cmd %x\n",
-                        (msg->data[0] >> 2) | 1, msg->data[1],
-                        msg->rsp[0] >> 2, msg->rsp[1]);
+               dev_warn_ratelimited(intf->si_dev,
+                                    "BMC returned incorrect response, expected netfn %x cmd %x, got netfn %x cmd %x\n",
+                                    (msg->data[0] >> 2) | 1, msg->data[1],
+                                    msg->rsp[0] >> 2, msg->rsp[1]);
 
                /* Generate an error response for the message. */
                msg->rsp[0] = msg->data[0] | (1 << 2);