Prevent `.DS_Store` in our zip files (#42123)

* Remove .DS_Store from dist building

* fix

* Build: exclude .DS_Store via zip -x instead of deleting files

Use zip's own `-x "*.DS_Store"` exclude in both the examples zip and the
release-zip script, rather than finding and removing files first. Cleaner
(doesn't mutate dist), and fixes the eslint error from filtering inside a
for…of loop header.

diff --git a/build/zip-examples.mjs b/build/zip-examples.mjs
index e66a939e301f375dff49aaadefe59226f8173fbd..93a40e0a1b55cabdb5a0fd1d530d979dc8b07c90 100644 (file)
--- a/build/zip-examples.mjs
+++ b/build/zip-examples.mjs
@@ -111,8 +111,8 @@ const formatPromises = htmlFiles.map(async file => {
 
 await Promise.all(formatPromises)
 
-// create the zip file
-sh.exec(`zip -qr9 "${distFolder}.zip" "${distFolder}"`)
+// create the zip file, excluding macOS .DS_Store files
+sh.exec(`zip -qr9 "${distFolder}.zip" "${distFolder}" -x "*.DS_Store"`)
 
 // remove the folder we created
 sh.rm('-rf', distFolder)

diff --git a/package.json b/package.json
index d4f601e464063a9f09166dba6f1dc82bc77169d5..f74a49d37cfeaf72862307652fdb59e5bde4b065 100644 (file)
--- a/package.json
+++ b/package.json
@@ -100,7 +100,7 @@
     "release": "npm-run-all dist release-sri docs-build release-zip*",
     "release-sri": "node build/generate-sri.mjs",
     "release-version": "node build/change-version.mjs",
-    "release-zip": "cross-env-shell \"rm -rf bootstrap-$npm_package_version-dist bootstrap-$npm_package_version-dist.zip && cp -r dist/ bootstrap-$npm_package_version-dist && zip -qr9 bootstrap-$npm_package_version-dist.zip bootstrap-$npm_package_version-dist && rm -rf bootstrap-$npm_package_version-dist\"",
+    "release-zip": "cross-env-shell \"rm -rf bootstrap-$npm_package_version-dist bootstrap-$npm_package_version-dist.zip && cp -r dist/ bootstrap-$npm_package_version-dist && zip -qr9 bootstrap-$npm_package_version-dist.zip bootstrap-$npm_package_version-dist -x \\\"*.DS_Store\\\" && rm -rf bootstrap-$npm_package_version-dist\"",
     "release-zip-examples": "node build/zip-examples.mjs",
     "dist": "npm-run-all --aggregate-output --parallel css js",
     "test": "npm-run-all lint dist js-test docs-build docs-lint",