s3-spoolss: Consistently fail OpenPrinterEx with "" printername

samba3.rpc.spoolss.printserver has become a flakey test recently, and this
papers over the real problem.

Andrew Bartlett

Signed-off-by: Günther Deschner <gd@samba.org>
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Mar 13 17:51:00 CET 2012 on sn-devel-104

diff --git a/source3/rpc_server/spoolss/srv_spoolss_nt.c b/source3/rpc_server/spoolss/srv_spoolss_nt.c
index f66bea8197ceb4802e5cc5f1fdc30075cbaa7045..daed9906fdc530a25763590a65c0eb290eaf7655 100644 (file)
--- a/source3/rpc_server/spoolss/srv_spoolss_nt.c
+++ b/source3/rpc_server/spoolss/srv_spoolss_nt.c
@@ -1710,6 +1710,10 @@ WERROR _spoolss_OpenPrinterEx(struct pipes_struct *p,
                return WERR_INVALID_PARAM;
        }
 
+       if (!*r->in.printername) {
+               return WERR_INVALID_PARAM;
+       }
+
        if (r->in.level > 3) {
                return WERR_INVALID_PARAM;
        }