x86/cpu: Fix overrun check in arch_print_cpu_modalias()

snprintf() does not return a negative value when truncating.

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Acked-by: Thomas Renninger <trenn@suse.de>
Acked-by: H. Peter Anvin <hpa@zytor.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/arch/x86/kernel/cpu/match.c b/arch/x86/kernel/cpu/match.c
index 940e2d483076a67410939970648c81306b9c3bd5..2dfa52bcdfe2c91de4f0f526a3f5fa175590d898 100644 (file)
--- a/arch/x86/kernel/cpu/match.c
+++ b/arch/x86/kernel/cpu/match.c
@@ -67,7 +67,7 @@ ssize_t arch_print_cpu_modalias(struct device *dev,
        for (i = 0; i < NCAPINTS*32; i++) {
                if (boot_cpu_has(i)) {
                        n = snprintf(buf, size, ",%04X", i);
-                       if (n < 0) {
+                       if (n >= size) {
                                WARN(1, "x86 features overflow page\n");
                                break;
                        }