net: ti: icssg-prueth: Add missing icss_iep_put to error path

[ Upstream commit e409d7346648c9acff84c3cc8d291767ee2d5326 ]

Analogously to prueth_remove, just also taking care for NULL'ing the
iep pointers.

Fixes: 186734c15886 ("net: ti: icssg-prueth: add packet timestamping and ptp support")
Fixes: 443a2367ba3c ("net: ti: icssg-prueth: am65x SR2.0 add 10M full duplex support")
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
Reviewed-by: MD Danish Anwar <danishanwar@ti.com>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth.c b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
index 4914d0ef58e9b969dc82401be4922a0d13b4e9ad..71d3001ec1ef8130a4082bf5e585e9f28a3a873f 100644 (file)
--- a/drivers/net/ethernet/ti/icssg/icssg_prueth.c
+++ b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
@@ -2092,10 +2092,7 @@ static int prueth_probe(struct platform_device *pdev)
        prueth->iep1 = icss_iep_get_idx(np, 1);
        if (IS_ERR(prueth->iep1)) {
                ret = dev_err_probe(dev, PTR_ERR(prueth->iep1), "iep1 get failed\n");
-               icss_iep_put(prueth->iep0);
-               prueth->iep0 = NULL;
-               prueth->iep1 = NULL;
-               goto free_pool;
+               goto put_iep0;
        }
 
        if (prueth->pdata.quirk_10m_link_issue) {
@@ -2185,6 +2182,12 @@ netdev_exit:
 exit_iep:
        if (prueth->pdata.quirk_10m_link_issue)
                icss_iep_exit_fw(prueth->iep1);
+       icss_iep_put(prueth->iep1);
+
+put_iep0:
+       icss_iep_put(prueth->iep0);
+       prueth->iep0 = NULL;
+       prueth->iep1 = NULL;
 
 free_pool:
        gen_pool_free(prueth->sram_pool,