]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
bpo-34871: inspect: Don't pollute sys.modules (GH-9696) (GH-9702)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Thu, 4 Oct 2018 19:26:27 +0000 (12:26 -0700)
committerYury Selivanov <yury@magic.io>
Thu, 4 Oct 2018 19:26:27 +0000 (15:26 -0400)
https://bugs.python.org/issue34871
(cherry picked from commit 6f85b826b527e240551613aeec3118a5469e3a33)

Co-authored-by: INADA Naoki <methane@users.noreply.github.com>
Lib/inspect.py
Misc/NEWS.d/next/Library/2018-10-04-18-46-54.bpo-34871.t3X-dB.rst [new file with mode: 0644]

index 227f6b8a63bd9b240020e21bb3373efe9a2f2984..dd3b784a607e9d95543780d06420aa6470f62a03 100644 (file)
@@ -1973,7 +1973,7 @@ def _signature_fromstr(cls, obj, s, skip_bound_arg=True):
         module = sys.modules.get(module_name, None)
         if module:
             module_dict = module.__dict__
-    sys_module_dict = sys.modules
+    sys_module_dict = sys.modules.copy()
 
     def parse_name(node):
         assert isinstance(node, ast.arg)
diff --git a/Misc/NEWS.d/next/Library/2018-10-04-18-46-54.bpo-34871.t3X-dB.rst b/Misc/NEWS.d/next/Library/2018-10-04-18-46-54.bpo-34871.t3X-dB.rst
new file mode 100644 (file)
index 0000000..8cff156
--- /dev/null
@@ -0,0 +1,2 @@
+Fix inspect module polluted ``sys.modules`` when parsing
+``__text_signature__`` of callable.