]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
io_uring/rw: don't lose short results on io_setup_async_rw()
authorPavel Begunkov <asml.silence@gmail.com>
Mon, 26 Sep 2022 23:44:40 +0000 (00:44 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 21 Oct 2022 10:37:33 +0000 (12:37 +0200)
commit c278d9f8ac0db5590909e6d9e85b5ca2b786704f upstream.

If a retry io_setup_async_rw() fails we lose result from the first
io_iter_do_read(), which is a problem mostly for streams/sockets.

Cc: stable@vger.kernel.org
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/0e8d20cebe5fc9c96ed268463c394237daabc384.1664235732.git.asml.silence@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
io_uring/rw.c

index 0a269d47185b12bd81d733def26bba875b0fd15c..295e3456d68ea059250b6325996f9ff23056a62e 100644 (file)
@@ -794,10 +794,12 @@ int io_read(struct io_kiocb *req, unsigned int issue_flags)
        iov_iter_restore(&s->iter, &s->iter_state);
 
        ret2 = io_setup_async_rw(req, iovec, s, true);
-       if (ret2)
-               return ret2;
-
        iovec = NULL;
+       if (ret2) {
+               ret = ret > 0 ? ret : ret2;
+               goto done;
+       }
+
        io = req->async_data;
        s = &io->s;
        /*