bnge: fix initial HWRM sequence

Firmware may not advertize correct resources if backing store is not
enabled before resource information is queried.
Fix the initial sequence of HWRMs so that driver gets capabilities
and resource information correctly.

Fixes: 3fa9e977a0cd ("bng_en: Initialize default configuration")
Signed-off-by: Vikas Gupta <vikas.gupta@broadcom.com>
Reviewed-by: Rahul Gupta <rahul-rg.gupta@broadcom.com>
Link: https://patch.msgid.link/20260418023438.1597876-2-vikas.gupta@broadcom.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_core.c b/drivers/net/ethernet/broadcom/bnge/bnge_core.c
index 1c14c5fe8d613231b38e9767c819fa363c365d81..68b74eb2c3a29a3d8a6ef000aca71cf99155e040 100644 (file)
--- a/drivers/net/ethernet/broadcom/bnge/bnge_core.c
+++ b/drivers/net/ethernet/broadcom/bnge/bnge_core.c
@@ -74,6 +74,13 @@ static int bnge_func_qcaps(struct bnge_dev *bd)
                return rc;
        }
 
+       return 0;
+}
+
+static int bnge_func_qrcaps_qcfg(struct bnge_dev *bd)
+{
+       int rc;
+
        rc = bnge_hwrm_func_resc_qcaps(bd);
        if (rc) {
                dev_err(bd->dev, "query resc caps failure rc: %d\n", rc);
@@ -133,23 +140,28 @@ static int bnge_fw_register_dev(struct bnge_dev *bd)
 
        bnge_hwrm_fw_set_time(bd);
 
-       rc =  bnge_hwrm_func_drv_rgtr(bd);
+       /* Get the resources and configuration from firmware */
+       rc = bnge_func_qcaps(bd);
        if (rc) {
-               dev_err(bd->dev, "Failed to rgtr with firmware rc: %d\n", rc);
+               dev_err(bd->dev, "Failed querying caps rc: %d\n", rc);
                return rc;
        }
 
        rc = bnge_alloc_ctx_mem(bd);
        if (rc) {
                dev_err(bd->dev, "Failed to allocate ctx mem rc: %d\n", rc);
-               goto err_func_unrgtr;
+               goto err_free_ctx_mem;
        }
 
-       /* Get the resources and configuration from firmware */
-       rc = bnge_func_qcaps(bd);
+       rc = bnge_hwrm_func_drv_rgtr(bd);
        if (rc) {
-               dev_err(bd->dev, "Failed initial configuration rc: %d\n", rc);
-               rc = -ENODEV;
+               dev_err(bd->dev, "Failed to rgtr with firmware rc: %d\n", rc);
+               goto err_free_ctx_mem;
+       }
+
+       rc = bnge_func_qrcaps_qcfg(bd);
+       if (rc) {
+               dev_err(bd->dev, "Failed querying resources rc: %d\n", rc);
                goto err_func_unrgtr;
        }
 
@@ -158,7 +170,9 @@ static int bnge_fw_register_dev(struct bnge_dev *bd)
        return 0;
 
 err_func_unrgtr:
-       bnge_fw_unregister_dev(bd);
+       bnge_hwrm_func_drv_unrgtr(bd);
+err_free_ctx_mem:
+       bnge_free_ctx_mem(bd);
        return rc;
 }