]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/rockchip: Return error code for errors
authorDaniel Stone <daniels@collabora.com>
Wed, 15 Oct 2025 11:00:32 +0000 (12:00 +0100)
committerHeiko Stuebner <heiko@sntech.de>
Mon, 20 Oct 2025 13:56:11 +0000 (15:56 +0200)
Instead of silently disabling small planes, refuse to create them at
all.

Signed-off-by: Daniel Stone <daniels@collabora.com>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/20251015110042.41273-4-daniels@collabora.com
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c

index f04fb5da12951b3f0c2e2bc21d6c04ae6a64aa36..659b2565dee42d32af6a02620752c432b832e0b6 100644 (file)
@@ -1035,8 +1035,7 @@ static int vop2_plane_atomic_check(struct drm_plane *plane,
                drm_dbg_kms(vop2->drm, "Invalid size: %dx%d->%dx%d, min size is 4x4\n",
                            drm_rect_width(src) >> 16, drm_rect_height(src) >> 16,
                            drm_rect_width(dest), drm_rect_height(dest));
-               pstate->visible = false;
-               return 0;
+               return -EINVAL;
        }
 
        if (drm_rect_width(src) >> 16 > vop2_data->max_input.width ||