Fix a memory leak in handling errors on CERTS cells. bug 7422

diff --git a/changes/bug7422 b/changes/bug7422
new file mode 100644 (file)
index 0000000..652f1a2
--- /dev/null
+++ b/changes/bug7422
@@ -0,0 +1,3 @@
+  o Minor bugfixes:
+    - Fix a memory leak on failing cases of channel_tls_process_certs_cell.
+      Fixes bug 7422; bugfix on 0.2.4.4-alpha.

diff --git a/src/or/channeltls.c b/src/or/channeltls.c
index d094d15af0a5702692988b5ec5ffdae229e5036a..ede245894e3be66296b4b33f89eafb65ea5c812b 100644 (file)
--- a/src/or/channeltls.c
+++ b/src/or/channeltls.c
@@ -1522,7 +1522,7 @@ channel_tls_process_certs_cell(var_cell_t *cell, channel_tls_t *chan)
            safe_str(chan->conn->base_.address),                 \
            chan->conn->base_.port, (s));                        \
     connection_or_close_for_error(chan->conn, 0);               \
-    return;                                                     \
+    goto err;                                                   \
   } while (0)
 
   if (chan->conn->base_.state != OR_CONN_STATE_OR_HANDSHAKING_V3)