]> git.ipfire.org Git - thirdparty/open-vm-tools.git/commitdiff
lib/file: clean up before a change
authorVMware, Inc <>
Thu, 22 Dec 2011 00:36:35 +0000 (16:36 -0800)
committerMarcelo Vanzin <mvanzin@vmware.com>
Thu, 22 Dec 2011 00:36:35 +0000 (16:36 -0800)
Make the new code more consistent with the existing code.

Signed-off-by: Marcelo Vanzin <mvanzin@vmware.com>
open-vm-tools/lib/file/fileLockPrimitive.c

index f347b750c35bf8582efd2fd8993d5e8d9a0f7efb..bf98721c6d2483b25ea1537a18251fb6612cd408 100644 (file)
@@ -1898,14 +1898,15 @@ FileLockIsLockedMandatory(ConstUnicode lockFile,  // IN:
     * Check for lock by actually locking file, and dropping
     * lock quickly if open was successful.
     */
+
    access = FILEIO_OPEN_ACCESS_READ | FILEIO_OPEN_ACCESS_WRITE |
             FILEIO_OPEN_EXCLUSIVE_LOCK;
-   result = FileIOCreateRetry(&desc, lockFile, access,
-                              FILEIO_OPEN, 0644,
-                              0);
+
+   result = FileIOCreateRetry(&desc, lockFile, access, FILEIO_OPEN, 0644, 0);
+
    if (FileIO_IsSuccess(result)) {
-      Bool ret;
-      ret = FileIO_Close(&desc);
+      Bool ret = FileIO_Close(&desc);
+
       ASSERT(!ret);
       return FALSE;
    } else if (result == FILEIO_LOCK_FAILED) {
@@ -1914,6 +1915,7 @@ FileLockIsLockedMandatory(ConstUnicode lockFile,  // IN:
       return FALSE;  // no lock file means unlocked
    } else {
       *err = FileMapErrorToErrno(__FUNCTION__, Err_Errno());
+
       return FALSE;
    }
 }