mm: simplify VMA flag tests of excluded flags

We have implemented flag mask comparisons of the form:

if ((vm_flags & (VM_FOO|VM_BAR|VM_BAZ) == VM_FOO) { ... }

Like-for-like in the code using a bitwise-and mask via vma_flags_and() and
using vma_flags_same() to ensure the final result equals only the required
flag value.

This is fine but confusing, make things clearer by instead explicitly
excluding undesired flags and including the desired one via tests of the
form:

	if (vma_flags_test(&flags, VMA_FOO_BIT) &&
	    !vma_flags_test_any(&flags, VMA_BAR_BIT, VMA_BAZ_BIT)) { ... }

Which makes it easier to understand what is going on.

No functional change intended.

Link: https://lkml.kernel.org/r/d395c5dd837a9864f5efcec42175910afbe3ce73.1774034900.git.ljs@kernel.org
Signed-off-by: Lorenzo Stoakes (Oracle) <ljs@kernel.org>
Suggested-by: Vlastimil Babka (SUSE) <vbabka@kernel.org>
Acked-by: Vlastimil Babka (SUSE) <vbabka@kernel.org>
Cc: Albert Ou <aou@eecs.berkeley.edu>
Cc: Alexander Gordeev <agordeev@linux.ibm.com>
Cc: Alexandre Ghiti <alex@ghiti.fr>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com>
Cc: "Borislav Petkov (AMD)" <bp@alien8.de>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Chengming Zhou <chengming.zhou@linux.dev>
Cc: Christian Borntraeger <borntraeger@linux.ibm.com>
Cc: Christian Brauner <brauner@kernel.org>
Cc: David Hildenbrand <david@kernel.org>
Cc: Dinh Nguyen <dinguyen@kernel.org>
Cc: Heiko Carstens <hca@linux.ibm.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Huacai Chen <chenhuacai@kernel.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jan Kara <jack@suse.cz>
Cc: Jann Horn <jannh@google.com>
Cc: Johannes Berg <johannes@sipsolutions.net>
Cc: Kees Cook <kees@kernel.org>
Cc: Liam Howlett <liam.howlett@oracle.com>
Cc: Madhavan Srinivasan <maddy@linux.ibm.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Mike Rapoport <rppt@kernel.org>
Cc: Nicholas Piggin <npiggin@gmail.com>
Cc: Ondrej Mosnacek <omosnace@redhat.com>
Cc: Palmer Dabbelt <palmer@dabbelt.com>
Cc: Paul Moore <paul@paul-moore.com>
Cc: Pedro Falcato <pfalcato@suse.de>
Cc: Richard Weinberger <richard@nod.at>
Cc: Russell King <linux@armlinux.org.uk>
Cc: Stephen Smalley <stephen.smalley.work@gmail.com>
Cc: Suren Baghdasaryan <surenb@google.com>
Cc: Sven Schnelle <svens@linux.ibm.com>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Vasily Gorbik <gor@linux.ibm.com>
Cc: Vineet Gupta <vgupta@kernel.org>
Cc: WANG Xuerui <kernel@xen0n.name>
Cc: Will Deacon <will@kernel.org>
Cc: xu xin <xu.xin16@zte.com.cn>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

diff --git a/mm/mprotect.c b/mm/mprotect.c
index 007d9a72b2f030268c8e4303f1b19bd512e200ee..110d47a36d4bbd262512dd7865b74a3d1cc80c95 100644 (file)
--- a/mm/mprotect.c
+++ b/mm/mprotect.c
@@ -784,14 +784,10 @@ mprotect_fixup(struct vma_iterator *vmi, struct mmu_gather *tlb,
         * Private VM_LOCKED VMA becoming writable: trigger COW to avoid major
         * fault on access.
         */
-       if (vma_flags_test(&new_vma_flags, VMA_WRITE_BIT)) {
-               const vma_flags_t mask =
-                       vma_flags_and(&old_vma_flags, VMA_WRITE_BIT,
-                                     VMA_SHARED_BIT, VMA_LOCKED_BIT);
-
-               if (vma_flags_same(&mask, VMA_LOCKED_BIT))
-                       populate_vma_page_range(vma, start, end, NULL);
-       }
+       if (vma_flags_test(&new_vma_flags, VMA_WRITE_BIT) &&
+           vma_flags_test(&old_vma_flags, VMA_LOCKED_BIT) &&
+           !vma_flags_test_any(&old_vma_flags, VMA_WRITE_BIT, VMA_SHARED_BIT))
+               populate_vma_page_range(vma, start, end, NULL);
 
        vm_stat_account(mm, vma_flags_to_legacy(old_vma_flags), -nrpages);
        newflags = vma_flags_to_legacy(new_vma_flags);

diff --git a/mm/vma.c b/mm/vma.c
index c335f989586ff9ba062e269e15e699ca184300c7..a4b30a069153f2c955414e8a4aaab6a596294f99 100644 (file)
--- a/mm/vma.c
+++ b/mm/vma.c
@@ -2343,7 +2343,6 @@ void mm_drop_all_locks(struct mm_struct *mm)
 static bool accountable_mapping(struct mmap_state *map)
 {
        const struct file *file = map->file;
-       vma_flags_t mask;
 
        /*
         * hugetlb has its own accounting separate from the core VM
@@ -2352,9 +2351,9 @@ static bool accountable_mapping(struct mmap_state *map)
        if (file && is_file_hugepages(file))
                return false;
 
-       mask = vma_flags_and(&map->vma_flags, VMA_NORESERVE_BIT, VMA_SHARED_BIT,
-                            VMA_WRITE_BIT);
-       return vma_flags_same(&mask, VMA_WRITE_BIT);
+       return vma_flags_test(&map->vma_flags, VMA_WRITE_BIT) &&
+               !vma_flags_test_any(&map->vma_flags, VMA_NORESERVE_BIT,
+                                   VMA_SHARED_BIT);
 }
 
 /*

diff --git a/mm/vma.h b/mm/vma.h
index adc18f7dd9f1b1a10eaf75c083702669b84d3368..1bfe7e47f6be7581e9bc7fee985609447af0f33e 100644 (file)
--- a/mm/vma.h
+++ b/mm/vma.h
@@ -529,10 +529,8 @@ static inline bool is_data_mapping(vm_flags_t flags)
 
 static inline bool is_data_mapping_vma_flags(const vma_flags_t *vma_flags)
 {
-       const vma_flags_t mask = vma_flags_and(vma_flags,
-                       VMA_WRITE_BIT, VMA_SHARED_BIT, VMA_STACK_BIT);
-
-       return vma_flags_same(&mask, VMA_WRITE_BIT);
+       return vma_flags_test(vma_flags, VMA_WRITE_BIT) &&
+               !vma_flags_test_any(vma_flags, VMA_SHARED_BIT, VMA_STACK_BIT);
 }
 
 static inline void vma_iter_config(struct vma_iterator *vmi,