]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
can: rcar_can: Convert to %pe
authorGeert Uytterhoeven <geert+renesas@glider.be>
Fri, 22 Aug 2025 10:17:12 +0000 (12:17 +0200)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Fri, 19 Sep 2025 17:25:17 +0000 (19:25 +0200)
Replace numerical error codes by mnemotechnic error codes, to improve
the user experience in case of errors.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
Link: https://patch.msgid.link/adb2dc49c78b45191de410f645a5e423d341f94e.1755857536.git.geert+renesas@glider.be
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/rcar/rcar_can.c

index 51bf8f7e71824ac8b6bdf77808e6854e1c518b73..5f85f4e272054789924f32734ade178f24603b12 100644 (file)
@@ -521,20 +521,20 @@ static int rcar_can_open(struct net_device *ndev)
        }
        err = clk_prepare_enable(priv->can_clk);
        if (err) {
-               netdev_err(ndev, "failed to enable CAN clock, error %d\n",
-                          err);
+               netdev_err(ndev, "failed to enable CAN clock: %pe\n",
+                          ERR_PTR(err));
                goto out_rpm;
        }
        err = open_candev(ndev);
        if (err) {
-               netdev_err(ndev, "open_candev() failed, error %d\n", err);
+               netdev_err(ndev, "open_candev() failed %pe\n", ERR_PTR(err));
                goto out_can_clock;
        }
        napi_enable(&priv->napi);
        err = request_irq(ndev->irq, rcar_can_interrupt, 0, ndev->name, ndev);
        if (err) {
-               netdev_err(ndev, "request_irq(%d) failed, error %d\n",
-                          ndev->irq, err);
+               netdev_err(ndev, "request_irq(%d) failed %pe\n", ndev->irq,
+                          ERR_PTR(err));
                goto out_close;
        }
        rcar_can_start(ndev);
@@ -786,8 +786,8 @@ static int rcar_can_probe(struct platform_device *pdev)
        }
        priv->can_clk = devm_clk_get(dev, clock_names[clock_select]);
        if (IS_ERR(priv->can_clk)) {
+               dev_err(dev, "cannot get CAN clock: %pe\n", priv->can_clk);
                err = PTR_ERR(priv->can_clk);
-               dev_err(dev, "cannot get CAN clock, error %d\n", err);
                goto fail_clk;
        }
 
@@ -813,7 +813,7 @@ static int rcar_can_probe(struct platform_device *pdev)
 
        err = register_candev(ndev);
        if (err) {
-               dev_err(dev, "register_candev() failed, error %d\n", err);
+               dev_err(dev, "register_candev() failed %pe\n", ERR_PTR(err));
                goto fail_rpm;
        }