]> git.ipfire.org Git - thirdparty/tor.git/commitdiff
Fix a harmless memory leak in tor-gencert
authorNick Mathewson <nickm@torproject.org>
Tue, 5 May 2015 15:05:01 +0000 (11:05 -0400)
committerNick Mathewson <nickm@torproject.org>
Tue, 5 May 2015 15:05:01 +0000 (11:05 -0400)
src/tools/tor-gencert.c

index c0cab7efe7fb8dd6eee160ac7776863d3e8367f7..28b1a58d528d449b27d4d0cbd97860a43081d0fa 100644 (file)
@@ -186,8 +186,7 @@ parse_commandline(int argc, char **argv)
         return 1;
       in.s_addr = htonl(addr);
       tor_inet_ntoa(&in, b, sizeof(b));
-      address = tor_malloc(INET_NTOA_BUF_LEN+32);
-      tor_snprintf(address, INET_NTOA_BUF_LEN+32, "%s:%d", b, (int)port);
+      tor_asprintf(&address, "%s:%d", b, (int)port);
     } else if (!strcmp(argv[i], "--create-identity-key")) {
       make_new_id = 1;
     } else if (!strcmp(argv[i], "--passphrase-fd")) {
@@ -566,6 +565,7 @@ main(int argc, char **argv)
   tor_free(identity_key_file);
   tor_free(signing_key_file);
   tor_free(certificate_file);
+  tor_free(address);
 
   crypto_global_cleanup();
   return r;