]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
Issue #12650: fix failures on some buildbots, when a subprocess takes a long
authorCharles-François Natali <neologix@free.fr>
Thu, 18 Aug 2011 22:24:00 +0000 (00:24 +0200)
committerCharles-François Natali <neologix@free.fr>
Thu, 18 Aug 2011 22:24:00 +0000 (00:24 +0200)
time to spawn.

Lib/test/test_subprocess.py

index 06b0f0e1133bea892f7912f07e4a92ab90c70477..b3a5fb0138e9a44e65386b2ee5d4b85031df122b 100644 (file)
@@ -1410,18 +1410,6 @@ class POSIXProcessTestCase(BaseTestCase):
         # check that p is in the active processes list
         self.assertIn(ident, [id(o) for o in subprocess._active])
 
-        # sleep a little to let the process exit, and create a new Popen: this
-        # should trigger the wait() of p
-        time.sleep(1)
-        with self.assertRaises(EnvironmentError) as c:
-            with subprocess.Popen(['nonexisting_i_hope'],
-                                  stdout=subprocess.PIPE,
-                                  stderr=subprocess.PIPE) as proc:
-                pass
-        # p should have been wait()ed on, and removed from the _active list
-        self.assertRaises(OSError, os.waitpid, pid, 0)
-        self.assertNotIn(ident, [id(o) for o in subprocess._active])
-
     def test_leak_fast_process_del_killed(self):
         # Issue #12650: on Unix, if Popen.__del__() was called before the
         # process exited, and the process got killed by a signal, it would never