]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
Input: psxpad-spi - set driver data before use
authorLinmao Li <lilinmao@kylinos.cn>
Sat, 25 Jul 2026 01:42:06 +0000 (18:42 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Sat, 25 Jul 2026 01:45:30 +0000 (18:45 -0700)
psxpad_spi_suspend() retrieves the controller state with
spi_get_drvdata(), but probe never stores it, so suspend dereferences a
NULL pointer. Store it during probe.

Fixes: 8be193c7b1f4 ("Input: add support for PlayStation 1/2 joypads connected via SPI")
Signed-off-by: Linmao Li <lilinmao@kylinos.cn>
Cc: stable@vger.kernel.org
Link: https://patch.msgid.link/20260721055551.1714965-1-lilinmao@kylinos.cn
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/joystick/psxpad-spi.c

index f902a56d011f4e3cb18976164b923d025ec629e5..aac77a2cfe468f078843d6e1a3ac6a9cddd971f4 100644 (file)
@@ -373,6 +373,7 @@ static int psxpad_spi_probe(struct spi_device *spi)
                return err;
        }
 
+       spi_set_drvdata(spi, pad);
        pm_runtime_enable(&spi->dev);
 
        return 0;