re PR target/52898 (SH Target: Inefficient DImode comparisons)

	PR target/52898
	PR target/51697
	* common/config/sh/sh-common.c (sh_option_optimization_table): Remove
	OPT_mcbranchdi entry.
	* config/sh/sh.opt (mcbranchdi, mcmpeqdi): Mark as undocumented and
	emit a warning.
	* config/sh/sh.c (sh_option_override): Initialize TARGET_CBRANCHDI4
	and TARGET_CMPEQDI_T variables.
	* doc/invoke.texi (SH options): Undocument -mcbranchdi and -mcmpeqdi.

	PR target/52898
	PR target/51697
	* gcc.target/sh/pr51697.c: New.

From-SVN: r205794

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 0c026c233cbac87367b9cc817657c7606d2a79e1..18537e8ead036ea3dffaae98a05e1d755feb2ba6 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,15 @@
+2013-12-08  Oleg Endo  <olegendo@gcc.gnu.org>
+
+       PR target/52898
+       PR target/51697
+       * common/config/sh/sh-common.c (sh_option_optimization_table): Remove
+       OPT_mcbranchdi entry.
+       * config/sh/sh.opt (mcbranchdi, mcmpeqdi): Mark as undocumented and
+       emit a warning.
+       * config/sh/sh.c (sh_option_override): Initialize TARGET_CBRANCHDI4
+       and TARGET_CMPEQDI_T variables.
+       * doc/invoke.texi (SH options): Undocument -mcbranchdi and -mcmpeqdi.
+
 2013-12-07  Maxim Kuvyrkov  <maxim@kugelworks.com>
 
        * config/linux.h: Fix typo in a comment.

diff --git a/gcc/common/config/sh/sh-common.c b/gcc/common/config/sh/sh-common.c
index f7fb9f5641ccb88258019efa47241943310e4767..cd4295a113806847a3de68b5232327cbebb11f3f 100644 (file)
--- a/gcc/common/config/sh/sh-common.c
+++ b/gcc/common/config/sh/sh-common.c
@@ -34,7 +34,6 @@ static const struct default_options sh_option_optimization_table[] =
     { OPT_LEVELS_1_PLUS_SPEED_ONLY, OPT_mdiv_, "inv:minlat", 1 },
     { OPT_LEVELS_SIZE, OPT_mdiv_, SH_DIV_STR_FOR_SIZE, 1 },
     { OPT_LEVELS_0_ONLY, OPT_mdiv_, "", 1 },
-    { OPT_LEVELS_SIZE, OPT_mcbranchdi, NULL, 0 },
     /* We can't meaningfully test TARGET_SHMEDIA here, because -m
        options haven't been parsed yet, hence we'd read only the
        default.  sh_target_reg_class will return NO_REGS if this is

diff --git a/gcc/config/sh/sh.c b/gcc/config/sh/sh.c
index 3e907b24a9d15df80b6c437bfd569581bbdd3f72..519892e1855d29e2c61fda1c1a683d1f7eeb89e8 100644 (file)
--- a/gcc/config/sh/sh.c
+++ b/gcc/config/sh/sh.c
@@ -771,6 +771,11 @@ sh_option_override (void)
   SUBTARGET_OVERRIDE_OPTIONS;
   if (optimize > 1 && !optimize_size)
     target_flags |= MASK_SAVE_ALL_TARGET_REGS;
+
+  /* Set default values of TARGET_CBRANCHDI4 and TARGET_CMPEQDI_T.  */
+  TARGET_CBRANCHDI4 = 1;
+  TARGET_CMPEQDI_T = 0;
+
   sh_cpu = PROCESSOR_SH1;
   assembler_dialect = 0;
   if (TARGET_SH2)

diff --git a/gcc/config/sh/sh.opt b/gcc/config/sh/sh.opt
index 8a6788eb3d1e16fe49fc4135704db9c0e7e84116..2a782c0e596e909214fae37be1d157d6941ec5d1 100644 (file)
--- a/gcc/config/sh/sh.opt
+++ b/gcc/config/sh/sh.opt
@@ -233,11 +233,11 @@ Target Var(TARGET_ZDCBRANCH)
 Assume that zero displacement conditional branches are fast
 
 mcbranchdi
-Target Var(TARGET_CBRANCHDI4)
+Target Undocumented Var(TARGET_CBRANCHDI4) Warn(%qs is deprecated and has no effect)
 Enable cbranchdi4 pattern
 
 mcmpeqdi
-Target Var(TARGET_CMPEQDI_T)
+Target Undocumented Var(TARGET_CMPEQDI_T) Warn(%qs is deprecated and has no effect)
 Emit cmpeqdi_t pattern even when -mcbranchdi is in effect.
 
 mcut2-workaround

diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
index 76149a3b8ff0e82e3e379ffeb009577d770d9962..bda4c198806ecee504f5299f21e2d254ec920ad3 100644 (file)
--- a/gcc/doc/invoke.texi
+++ b/gcc/doc/invoke.texi
@@ -959,7 +959,7 @@ See RS/6000 and PowerPC Options.
 -mindexed-addressing -mgettrcost=@var{number} -mpt-fixed @gol
 -maccumulate-outgoing-args -minvalid-symbols @gol
 -matomic-model=@var{atomic-model} @gol
--mbranch-cost=@var{num} -mzdcbranch -mno-zdcbranch -mcbranchdi -mcmpeqdi @gol
+-mbranch-cost=@var{num} -mzdcbranch -mno-zdcbranch @gol
 -mfused-madd -mno-fused-madd -mfsca -mno-fsca -mfsrra -mno-fsrra @gol
 -mpretend-cmove -mtas}
 
@@ -20252,15 +20252,6 @@ compiler will try to prefer zero displacement branch code sequences.  This is
 enabled by default when generating code for SH4 and SH4A.  It can be explicitly
 disabled by specifying @option{-mno-zdcbranch}.
 
-@item -mcbranchdi
-@opindex mcbranchdi
-Enable the @code{cbranchdi4} instruction pattern.
-
-@item -mcmpeqdi
-@opindex mcmpeqdi
-Emit the @code{cmpeqdi_t} instruction pattern even when @option{-mcbranchdi}
-is in effect.
-
 @item -mfused-madd
 @itemx -mno-fused-madd
 @opindex mfused-madd

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index a67489420b1cf50189a7347da5b59986c935d3cd..9acf500147b0ef8345a22be232ccb62a4af9456a 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,9 @@
+2013-12-08  Oleg Endo  <olegendo@gcc.gnu.org>
+
+       PR target/52898
+       PR target/51697
+       * gcc.target/sh/pr51697.c: New.
+
 2013-12-08  Uros Bizjak  <ubizjak@gmail.com>
 
        * gcc.dg/macro-fusion-1.c: Cleanup sched2 rtl dump.

diff --git a/gcc/testsuite/gcc.target/sh/pr51697.c b/gcc/testsuite/gcc.target/sh/pr51697.c
new file mode 100644 (file)
index 0000000..d63e329
--- /dev/null
+++ b/gcc/testsuite/gcc.target/sh/pr51697.c
@@ -0,0 +1,21 @@
+/* Check that DImode comparisons are optimized as expected when compiling
+   with -Os.  */
+/* { dg-do compile }  */
+/* { dg-options "-Os" } */
+/* { dg-skip-if "" { "sh*-*-*" } { "-m5*"} { "" } }  */
+/* { dg-final { scan-assembler-times "tst" 2 } }  */
+/* { dg-final { scan-assembler-not "cmp" } }  */
+
+int
+test_00 (long long* x)
+{
+  /* 1x tst, no cmp/* insns.  */
+  return *x & 0xFFFFFFFF ? -20 : -40;
+}
+
+int
+test_01 (unsigned long long x)
+{
+  /* 1x tst, no cmp/* insns.  */
+  return x >= 0x100000000LL ? -20 : -40;
+}