]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
TEST-07-PID1: Lower TriggerLimitIntervalSec= unconditionally
authorDaan De Meyer <daan.j.demeyer@gmail.com>
Sat, 4 May 2024 11:22:53 +0000 (13:22 +0200)
committerDaan De Meyer <daan.j.demeyer@gmail.com>
Mon, 6 May 2024 09:57:09 +0000 (11:57 +0200)
It shouldn't hurt to do this when KVM is enabled or we're not collecting
coverage so let's just always lower the trigger limit interval.

test/TEST-07-PID1/test.sh
test/testsuite-07.units/issue2467.socket

index b60f1db68fddbd20914746995140fde264a7f8bd..2513406e0de484b343cea1f706cde97fd2751e54 100755 (executable)
@@ -11,16 +11,6 @@ NSPAWN_ARGUMENTS="--capability=CAP_NET_ADMIN"
 . "${TEST_BASE_DIR:?}/test-functions"
 
 test_append_files() {
-    local workspace="${1:?}"
-
-    # We might not be fast enough to hit the limit (20 triggers per 2 secs)
-    # in certain environments, i.e. when running without KVM or when collecting
-    # coverage. Let's help it a bit in such case.
-    if ! get_bool "$QEMU_KVM" || get_bool "$IS_BUILT_WITH_COVERAGE"; then
-        mkdir -p "$workspace/etc/systemd/system/issue2467.socket.d"
-        printf "[Socket]\nTriggerLimitIntervalSec=10\n" >"$workspace/etc/systemd/system/issue2467.socket.d/TriggerLimitInterval.conf"
-    fi
-
     image_install logger socat
 }
 
index af1317b409d12ee6790970392cbaa6e82fe083a7..209b6bbce5d3632bc4a272ed486a59a3ee4f647a 100644 (file)
@@ -1,3 +1,7 @@
 # SPDX-License-Identifier: LGPL-2.1-or-later
 [Socket]
 ListenStream=/run/test.ctl
+# We might not be fast enough to hit the default limit (20 triggers per 2 secs)
+# in certain environments, i.e. when running without KVM or when collecting
+# coverage. Let's help it a bit in such cases by lowering the limit to 10 seconds.
+TriggerLimitIntervalSec=10