[1237] Minor fixes after review.

diff --git a/src/bin/dhcp6/dhcp6_srv.cc b/src/bin/dhcp6/dhcp6_srv.cc
index b1264562645a788e496c518bcff8d7670c23d2b5..c0f050f020a68ed00110e57728975660c8bddaf4 100644 (file)
--- a/src/bin/dhcp6/dhcp6_srv.cc
+++ b/src/bin/dhcp6/dhcp6_srv.cc
@@ -33,7 +33,7 @@ Dhcpv6Srv::Dhcpv6Srv(uint16_t port) {
     try {
        IfaceMgr::instance();
     } catch (const std::exception &e) {
-       cout << "Failed to instantiate InterfaceManager. Aborting." << endl;
+       cout << "Failed to instantiate InterfaceManager:" << e.what() << ". Aborting." << endl;
        shutdown = true;
     }
 

diff --git a/src/lib/dhcp/iface_mgr.cc b/src/lib/dhcp/iface_mgr.cc
index 651c07bdf46426b2994ca33beb443546e2ac39fc..d9310db0b72edd44d7090972ec9026addb4dc838 100644 (file)
--- a/src/lib/dhcp/iface_mgr.cc
+++ b/src/lib/dhcp/iface_mgr.cc
@@ -12,6 +12,7 @@
 // OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
 // PERFORMANCE OF THIS SOFTWARE.
 
+#include <config.h>
 #include <sstream>
 #include <fstream>
 #include <string.h>
@@ -73,7 +74,7 @@ IfaceMgr::Iface::getPlainMac() const {
     tmp << hex;
     for (int i = 0; i < mac_len_; i++) {
         tmp.width(2);
-        tmp <<  int(mac_[i]);
+        tmp <<  static_cast<int>(mac_[i]);
         if (i < mac_len_-1) {
             tmp << ":";
         }

diff --git a/src/lib/dhcp/iface_mgr.h b/src/lib/dhcp/iface_mgr.h
index 2155ae8249ef03f35d1eb0b106c4da126b19918c..47accc8a1b1817fe29c5c74838c444e820c4c05e 100644 (file)
--- a/src/lib/dhcp/iface_mgr.h
+++ b/src/lib/dhcp/iface_mgr.h
@@ -54,6 +54,12 @@ public:
         /// returns link-layer address a plain text
         std::string getPlainMac() const;
 
+        /// @brief Sets flag_*_ fields based on bitmask value returned by OS
+        ///
+        /// Note: Implementation of this method is OS-dependent as bits have
+        /// different meaning on each OS.
+        ///
+        /// @param flags bitmask value returned by OS in interface detection
         void setFlags(uint32_t flags);
 
         /// network interface name