patch 8.1.1749: Coverity warns for using negative index

Problem:    Coverity warns for using negative index.
Solution:   Move using index inside "if".

diff --git a/src/version.c b/src/version.c
index d1dde86a02704e86a718b638adbc826f69367306..1a65cef769a581459c1f6a98a4c2901a259f459d 100644 (file)
--- a/src/version.c
+++ b/src/version.c
@@ -777,6 +777,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    1749,
 /**/
     1748,
 /**/

diff --git a/src/viminfo.c b/src/viminfo.c
index cd3bbb65c6ed854951d7f116f5e0bc2136a31f55..1b09414bece06e985e095a78cb135b70facc9755 100644 (file)
--- a/src/viminfo.c
+++ b/src/viminfo.c
@@ -1420,9 +1420,9 @@ read_viminfo_search_pattern(vir_T *virp, int force)
     else if (lp[0] == 'H')     // ~H: 'hlsearch' highlighting on
        hlsearch_on = TRUE;
 #endif
-    spat = get_spat(idx);
     if (idx >= 0)
     {
+       spat = get_spat(idx);
        if (force || spat->pat == NULL)
        {
            val = viminfo_readstring(virp, (int)(lp - virp->vir_line + 1),