CVE-2021-3738 s4:torture/drsuapi: maintain priv->dc_credentials

We want to use the credentials of the joined dc account
in future tests.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14468

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/source4/torture/rpc/drsuapi.c b/source4/torture/rpc/drsuapi.c
index 862c5f592b7b0c96d245ebf81f8c42e7bfd89e8a..1cd595e5d8e9a40308cab46471eed9e06eda0f72 100644 (file)
--- a/source4/torture/rpc/drsuapi.c
+++ b/source4/torture/rpc/drsuapi.c
@@ -774,7 +774,6 @@ bool torture_drsuapi_tcase_setup_common(struct torture_context *tctx, struct DsP
        NTSTATUS status;
        int rnd = rand() % 1000;
        char *name = talloc_asprintf(tctx, "%s%d", TEST_MACHINE_NAME, rnd);
-       struct cli_credentials *machine_credentials;
 
        torture_assert(tctx, priv, "Invalid argument");
 
@@ -786,7 +785,7 @@ bool torture_drsuapi_tcase_setup_common(struct torture_context *tctx, struct DsP
 
        torture_comment(tctx, "About to join domain with name %s\n", name);
        priv->join = torture_join_domain(tctx, name, ACB_SVRTRUST,
-                                        &machine_credentials);
+                                        &priv->dc_credentials);
        torture_assert(tctx, priv->join, "Failed to join as BDC");
 
        if (!test_DsBind(priv->drs_pipe, tctx,

diff --git a/source4/torture/rpc/drsuapi.h b/source4/torture/rpc/drsuapi.h
index e81b2fe37469cb1d10ea1e2887d345d52511bf13..f327c54cda4476e328118eb69c4fd013c270f4b1 100644 (file)
--- a/source4/torture/rpc/drsuapi.h
+++ b/source4/torture/rpc/drsuapi.h
@@ -37,6 +37,7 @@ struct DsPrivate {
        struct GUID domain_guid;
        struct drsuapi_DsGetDCInfo2 dcinfo;
        struct test_join *join;
+       struct cli_credentials *dc_credentials;
 };
 
 /**