]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
spi: stm32-ospi: Fix resource leak in remove() callback
authorFelix Gu <ustc.gu@gmail.com>
Sun, 29 Mar 2026 11:14:05 +0000 (19:14 +0800)
committerMark Brown <broonie@kernel.org>
Mon, 30 Mar 2026 12:22:18 +0000 (13:22 +0100)
The remove() callback returned early if pm_runtime_resume_and_get()
failed, skipping the cleanup of spi controller and other resources.

Remove the early return so cleanup completes regardless of PM resume
result.

Fixes: 79b8a705e26c ("spi: stm32: Add OSPI driver")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
Link: https://patch.msgid.link/20260329-ospi-v1-1-cc8cf1c82c4a@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-stm32-ospi.c

index c98afe02a1b6b6e22a840fae009a4dac6a9162a1..2baf651c0a6da889beb5cb0af59d7c9d9e1b703f 100644 (file)
@@ -989,11 +989,8 @@ err_pm_enable:
 static void stm32_ospi_remove(struct platform_device *pdev)
 {
        struct stm32_ospi *ospi = platform_get_drvdata(pdev);
-       int ret;
 
-       ret = pm_runtime_resume_and_get(ospi->dev);
-       if (ret < 0)
-               return;
+       pm_runtime_resume_and_get(ospi->dev);
 
        spi_unregister_controller(ospi->ctrl);
        /* Disable ospi */