]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
fs: dlm: cancel work sync othercon
authorAlexander Aring <aahringo@redhat.com>
Fri, 21 May 2021 19:08:38 +0000 (15:08 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Jul 2021 14:55:58 +0000 (16:55 +0200)
[ Upstream commit c6aa00e3d20c2767ba3f57b64eb862572b9744b3 ]

These rx tx flags arguments are for signaling close_connection() from
which worker they are called. Obviously the receive worker cannot cancel
itself and vice versa for swork. For the othercon the receive worker
should only be used, however to avoid deadlocks we should pass the same
flags as the original close_connection() was called.

Signed-off-by: Alexander Aring <aahringo@redhat.com>
Signed-off-by: David Teigland <teigland@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/dlm/lowcomms.c

index 44e2716ac158003b2501e8ea3b73237370b97265..0c78fdfb1f6faaec81253a6535055cef23a0acc8 100644 (file)
@@ -599,7 +599,7 @@ static void close_connection(struct connection *con, bool and_other,
        }
        if (con->othercon && and_other) {
                /* Will only re-enter once. */
-               close_connection(con->othercon, false, true, true);
+               close_connection(con->othercon, false, tx, rx);
        }
 
        con->rx_leftover = 0;