]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
test-dhcp6-client: add one more assert on memory mapping 19117/head
authorLuca Boccassi <luca.boccassi@microsoft.com>
Thu, 25 Mar 2021 11:47:13 +0000 (11:47 +0000)
committerLuca Boccassi <luca.boccassi@microsoft.com>
Thu, 25 Mar 2021 12:02:43 +0000 (12:02 +0000)
Static analyzers need a hint that optval is not pointing
off the end of the msg_advertise array, since pos can go
up to the full length of it. The array is manually
constructed so we know this won't happen, but adding one
more assert should be enough to avoid false positives.

Coverity CID #1394277

src/libsystemd-network/test-dhcp6-client.c

index cb363b3973ff244dc8050eed8dc819f6435ff185..42cd91e0be38ce8bd3e1e39e90c725163f9f5ad0 100644 (file)
@@ -449,6 +449,7 @@ static int test_advertise_option(sd_event *e) {
 
                 case SD_DHCP6_OPTION_IA_NA:
                         assert_se(optlen == 94);
+                        assert_se(optval == &msg_advertise[26]);
                         assert_se(!memcmp(optval, &msg_advertise[26], optlen));
 
                         val = htobe32(0x0ecfa37d);