]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
sched_ext: Fix SCX_EFLAG_INITIALIZED being a no-op flag
authorDavid Carlier <devnexen@gmail.com>
Thu, 26 Feb 2026 12:45:17 +0000 (12:45 +0000)
committerTejun Heo <tj@kernel.org>
Thu, 26 Feb 2026 22:03:24 +0000 (12:03 -1000)
SCX_EFLAG_INITIALIZED is the sole member of enum scx_exit_flags with no
explicit value, so the compiler assigns it 0. This makes the bitwise OR
in scx_ops_init() a no-op:

    sch->exit_info->flags |= SCX_EFLAG_INITIALIZED; /* |= 0 */

As a result, BPF schedulers cannot distinguish whether ops.init()
completed successfully by inspecting exit_info->flags.

Assign the value 1LLU << 0 so the flag is actually set.

Fixes: f3aec2adce8d ("sched_ext: Add SCX_EFLAG_INITIALIZED to indicate successful ops.init()")
Signed-off-by: David Carlier <devnexen@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
kernel/sched/ext_internal.h

index 386c677e4c9a0ca81c9775c6de9b8a28f9314ec4..11ebb744d8931eef3dbcebec8c375390447a07fc 100644 (file)
@@ -74,7 +74,7 @@ enum scx_exit_flags {
         * info communication. The following flag indicates whether ops.init()
         * finished successfully.
         */
-       SCX_EFLAG_INITIALIZED,
+       SCX_EFLAG_INITIALIZED   = 1LLU << 0,
 };
 
 /*