]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
network: update log message 19332/head
authorYu Watanabe <watanabe.yu+github@gmail.com>
Fri, 16 Apr 2021 00:54:52 +0000 (09:54 +0900)
committerYu Watanabe <watanabe.yu+github@gmail.com>
Fri, 16 Apr 2021 10:48:54 +0000 (19:48 +0900)
In some optimization level with gcc, including netdev->ifname in log
message causes error.

src/network/netdev/netdev.c
src/network/netdev/wireguard.c

index b31f0fa81ab23f7c77fc604a28e37edd28c29635..81d9260c123968ad3d7e6b9baf6805cd9e62ca1f 100644 (file)
@@ -747,8 +747,7 @@ int netdev_load_one(Manager *manager, const char *filename) {
                 r = netdev_get_mac(netdev->ifname, &netdev->mac);
                 if (r < 0)
                         return log_netdev_error_errno(netdev, r,
-                                                      "Failed to generate predictable MAC address for %s: %m",
-                                                      netdev->ifname);
+                                                      "Failed to generate predictable MAC address: %m");
         }
 
         r = hashmap_ensure_put(&netdev->manager->netdevs, &string_hash_ops, netdev->ifname, netdev);
@@ -760,8 +759,8 @@ int netdev_load_one(Manager *manager, const char *filename) {
                 assert(n);
                 if (!streq(netdev->filename, n->filename))
                         log_netdev_warning_errno(netdev, r,
-                                                 "The setting Name=%s in %s conflicts with the one in %s, ignoring",
-                                                 netdev->ifname, netdev->filename, n->filename);
+                                                 "Device was already configured by file %s, ignoring %s.",
+                                                 n->filename, netdev->filename);
 
                 /* Clear ifname before netdev_free() is called. Otherwise, the NetDev object 'n' is
                  * removed from the hashmap 'manager->netdevs'. */
index 75d6d376a537994fedcced6b98f10916bb097ca7..b8fc492d4fcc91c881777a1ee8da39b644b5373d 100644 (file)
@@ -914,14 +914,13 @@ static int wireguard_verify(NetDev *netdev, const char *filename) {
         r = wireguard_read_key_file(w->private_key_file, w->private_key);
         if (r < 0)
                 return log_netdev_error_errno(netdev, r,
-                                              "Failed to read private key from %s. Dropping network device %s.",
-                                              w->private_key_file, netdev->ifname);
+                                              "Failed to read private key from %s. Ignoring network device.",
+                                              w->private_key_file);
 
         if (eqzero(w->private_key))
                 return log_netdev_error_errno(netdev, SYNTHETIC_ERRNO(EINVAL),
                                               "%s: Missing PrivateKey= or PrivateKeyFile=, "
-                                              "Dropping network device %s.",
-                                              filename, netdev->ifname);
+                                              "Ignoring network device.", filename);
 
         LIST_FOREACH_SAFE(peers, peer, peer_next, w->peers)
                 if (wireguard_peer_verify(peer) < 0)