rpc/dnsdata: avoid crash on missing attr (CID: 1414757)

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>

diff --git a/source4/rpc_server/dnsserver/dnsdata.c b/source4/rpc_server/dnsserver/dnsdata.c
index 6a211ad9efdfefc2d0ec5e41e779c037bca1822b..415a7c57a0f119711c81cac96024cea3d0f7b524 100644 (file)
--- a/source4/rpc_server/dnsserver/dnsdata.c
+++ b/source4/rpc_server/dnsserver/dnsdata.c
@@ -968,6 +968,12 @@ WERROR dns_fill_records_array(TALLOC_CTX *mem_ctx,
        }
 
        ptr = ldb_msg_find_attr_as_string(msg, "name", NULL);
+       if (ptr == NULL) {
+               DBG_ERR("dnsserver: dns record has no name (%s)",
+                       ldb_dn_get_linearized(msg->dn));
+               return WERR_INTERNAL_DB_ERROR;
+       }
+
        el = ldb_msg_find_element(msg, "dnsRecord");
        if (el == NULL || el->values == 0) {
                return WERR_OK;