]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ARM: exynos: Fix refcount leak in exynos_map_pmu
authorMiaoqian Lin <linmq006@gmail.com>
Mon, 23 May 2022 14:55:13 +0000 (18:55 +0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 2 Jul 2022 14:27:37 +0000 (16:27 +0200)
commit c4c79525042a4a7df96b73477feaf232fe44ae81 upstream.

of_find_matching_node() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.
of_node_put() checks null pointer.

Fixes: fce9e5bb2526 ("ARM: EXYNOS: Add support for mapping PMU base address via DT")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220523145513.12341-1-linmq006@gmail.com
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/arm/mach-exynos/exynos.c

index 865dcc4c3181a1e4540e094baa0ef976d876b0b5..23adb1a54bcd9cf96b867ed9458b194cdaa3ee93 100644 (file)
@@ -131,6 +131,7 @@ static void exynos_map_pmu(void)
        np = of_find_matching_node(NULL, exynos_dt_pmu_match);
        if (np)
                pmu_base_addr = of_iomap(np, 0);
+       of_node_put(np);
 }
 
 static void __init exynos_init_irq(void)