ctdb-tests: Avoid warning about NULL dereference

Static analysis finds that earlier in the call path, ctdb_string_len()
checks for NULL, so complains that a NULL value can be passed to
strlen() here.  Avoid this by adding an assert().

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

diff --git a/ctdb/tests/src/protocol_types_compat_test.c b/ctdb/tests/src/protocol_types_compat_test.c
index 0f1e548d099446fc0d826c77152d9db96a55f9b6..59aef825b72239b515ab75aab6931c13ff67e4bc 100644 (file)
--- a/ctdb/tests/src/protocol_types_compat_test.c
+++ b/ctdb/tests/src/protocol_types_compat_test.c
@@ -838,6 +838,7 @@ static size_t ctdb_var_list_len_old(struct ctdb_var_list *in)
        size_t len = sizeof(uint32_t);
 
        for (i=0; i<in->count; i++) {
+               assert(in->var[i] != NULL);
                len += strlen(in->var[i]) + 1;
        }
        return len;