]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: ccs: Avoid deadlock in ccs_init_state()
authorSakari Ailus <sakari.ailus@linux.intel.com>
Sat, 21 Mar 2026 21:21:44 +0000 (23:21 +0200)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Thu, 26 Mar 2026 12:14:07 +0000 (13:14 +0100)
The sub-device state lock has been already acquired when ccs_init_state()
is called. Do not try to acquire it again.

Reported-by: David Heidelberg <david@ixit.cz>
Fixes: a88883d1209c ("media: ccs: Rely on sub-device state locking")
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/i2c/ccs/ccs-core.c

index aa4dd7e7cf5adc002de021537bb2b845e1a823dc..8e25f970fd12c3ac737cac0e4f1e5a8f3b69dc66 100644 (file)
@@ -3080,8 +3080,6 @@ static int ccs_init_state(struct v4l2_subdev *sd,
        struct v4l2_rect *crop =
                v4l2_subdev_state_get_crop(sd_state, pad);
 
-       guard(mutex)(&sensor->mutex);
-
        ccs_get_native_size(ssd, crop);
 
        fmt->width = crop->width;