stop the infinite loop of freeing the same connection_t over and

over when it's not linked into the connection_array

svn:r3474

diff --git a/src/or/main.c b/src/or/main.c
index d47f0c762a20d16d9ddd25cb242070bfb07ff55f..edcc0a8dc238c7f45f5744345815f480999bd1d5 100644 (file)
--- a/src/or/main.c
+++ b/src/or/main.c
@@ -189,8 +189,8 @@ static void connection_unlink(connection_t *conn, int remove) {
   connection_about_to_close_connection(conn);
   if (remove) {
     connection_remove(conn);
-    smartlist_remove(closeable_connection_lst, conn);
   }
+  smartlist_remove(closeable_connection_lst, conn);
   if (conn->type == CONN_TYPE_EXIT) {
     assert_connection_edge_not_dns_pending(conn);
   }