crypto: qat - Drop redundant local variables

Return sysfs_emit() directly and drop 'ret' in cap_rem_show().

In cap_rem_store(), use 'ret' when calling set_param_u() instead of
assigning it to 'val' first, and remove 'val'.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Acked-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/drivers/crypto/intel/qat/qat_common/adf_sysfs_rl.c b/drivers/crypto/intel/qat/qat_common/adf_sysfs_rl.c
index f31556beed8b6f2c24949aa0e1bbd9027fa1fe9a..89bfd8761d756fdc9b6a7cadab5e47f867bfe712 100644 (file)
--- a/drivers/crypto/intel/qat/qat_common/adf_sysfs_rl.c
+++ b/drivers/crypto/intel/qat/qat_common/adf_sysfs_rl.c
@@ -321,7 +321,7 @@ static ssize_t cap_rem_show(struct device *dev, struct device_attribute *attr,
 {
        struct adf_rl_interface_data *data;
        struct adf_accel_dev *accel_dev;
-       int ret, rem_cap;
+       int rem_cap;
 
        accel_dev = adf_devmgr_pci_to_accel_dev(to_pci_dev(dev));
        if (!accel_dev)
@@ -336,23 +336,19 @@ static ssize_t cap_rem_show(struct device *dev, struct device_attribute *attr,
        if (rem_cap < 0)
                return rem_cap;
 
-       ret = sysfs_emit(buf, "%u\n", rem_cap);
-
-       return ret;
+       return sysfs_emit(buf, "%u\n", rem_cap);
 }
 
 static ssize_t cap_rem_store(struct device *dev, struct device_attribute *attr,
                             const char *buf, size_t count)
 {
-       unsigned int val;
        int ret;
 
        ret = sysfs_match_string(rl_services, buf);
        if (ret < 0)
                return ret;
 
-       val = ret;
-       ret = set_param_u(dev, CAP_REM_SRV, val);
+       ret = set_param_u(dev, CAP_REM_SRV, ret);
        if (ret)
                return ret;